1.7.0 with Namada #14
Conversation
yito88
force-pushed
the
yuji/1.7.0-namada
branch
from
3758262 to
665cec3
Compare
yito88
force-pushed
the
yuji/1.7.0-namada
branch
from
c456adf to
86f0e4d
Compare
yito88
force-pushed
the
yuji/1.7.0-namada
branch
from
86f0e4d to
e432c42
Compare
| @@ -20,7 +20,11 @@ jobs: | |||
| with: | |||
| toolchain: nightly-2023-07-13 | |||
| override: true | |||
|
|
|||
| - name: Install Protoc | |||
There was a problem hiding this comment.
do we really need to ask informal to make this a dependency?
There was a problem hiding this comment.
We can't build Hermes importing namada_sdk and namada without protoc.
| let response = self.send_tx(msg)?; | ||
|
|
||
| // Note: we don't have any height information in this case. This hack will fix itself | ||
| // once we remove the `ChainError` event (which is not actually an event) |
There was a problem hiding this comment.
There are only Cosmos-SDK chains using
They said we could open a PR for Namada. I will share this progress and ask them about it again. |
| .map_err(|_| eyre!("error loading Namada wallet"))?; | ||
|
|
||
| let secret_key = wallet | ||
| .find_secret_key(key_name, None) |
There was a problem hiding this comment.
passing None here will interrupt the process with a prompt, right? should we instead hand out the password via a secrets file or smth?
| Ok(monitor_tx) | ||
| } | ||
|
|
||
| fn get_unbonding_time(&self) -> Result<Duration, Error> { |
There was a problem hiding this comment.
| fn get_unbonding_time(&self) -> Result<Duration, Error> { | |
| fn get_min_unbonding_time(&self) -> Result<Duration, Error> { |
maybe? since this is not a precise duration (epochs can last longer than epoch_duration.min_duration)
| store.insert_keypair::<wallet::NullWalletUtils>( | ||
| config.key_name.clone().into(), | ||
| key.secret_key, | ||
| None, | ||
| Some(key.address), | ||
| None, | ||
| true, | ||
| ); |
There was a problem hiding this comment.
this won't encrypt the keys right? maybe we should add an option to do so, later on
closes #11
NamadatoChainConfigCosmosSdkConfigfor generating Tendermint light clientsNamadaChainasChainEndpointimplementationcrates/relayer/src/chain/namada.rsand files undercrates/relayer/src/chain/namadaKeyRingAdd Namada key to the store #15