Skip to content

Commit

Permalink
v1.13.4
Browse files Browse the repository at this point in the history
  • Loading branch information
heliomarpm committed Dec 7, 2024
1 parent 53f0bd8 commit 063bc3d
Show file tree
Hide file tree
Showing 4 changed files with 55 additions and 24 deletions.
8 changes: 8 additions & 0 deletions CHANGE_LOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change Log

## Version [1.13.4](https://github.com/heliomarpm/udemy-downloader-gui/compare/v1.13.3...v1.13.4)
##### Dec, 7 2024
![](https://img.shields.io/github/downloads/heliomarpm/udemy-downloader-gui/v1.13.4/total)

* Bug fixes
* Package update


## Version [1.13.3](https://github.com/heliomarpm/udemy-downloader-gui/compare/v1.13.2...v1.13.3)
##### Nov, 14 2024
![](https://img.shields.io/github/downloads/heliomarpm/udemy-downloader-gui/v1.13.3/total)
Expand Down
15 changes: 10 additions & 5 deletions app/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,8 @@ async function fetchCourseContent(courseId, courseName, courseUrl) {
lecture.src = `<script type="text/javascript">window.location = "${courseUrl}/${item._class}/${item.id}";</script>`;
appendLog("File not uploaded", `Course: ${courseId}|${courseName}`, `Lecture: ${item.id}|${item.title}`);
} else {
switch (lecture.quality.toLowerCase()) {

switch ( (lecture.quality || "").toLowerCase()) {
case "auto":
case "highest":
lecture.quality = streams.maxQuality;
Expand Down Expand Up @@ -1695,10 +1696,14 @@ function askForSubtitle(subtitlesAvailable, totalLectures, defaultSubtitle = "",
const totals = {};
const languageKeys = {};

if (Object.keys(subtitlesAvailable).length === 0) {
callback("");
return;
}
try {
if (subtitlesAvailable && Object.keys(subtitlesAvailable).length === 0) {
callback("");
return;
}
} catch (error) {
return;
}

defaultSubtitle = defaultSubtitle.replace(/\s*\[.*?\]/g, "").trim();
for (const key in subtitlesAvailable) {
Expand Down
43 changes: 30 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "udeler",
"productName": "Udeler",
"version": "1.13.3",
"version": "1.13.4",
"description": "A cross platform (Windows, Mac, Linux) desktop application for downloading Udemy Courses.",
"main": "main.js",
"type": "commonjs",
Expand Down Expand Up @@ -32,9 +32,9 @@
"sync:locales": "node ./sync-locales.js"
},
"dependencies": {
"@sentry/electron": "^4.24.0",
"axios": "^1.7.7",
"cookie": "^1.0.1",
"@sentry/electron": "4.24.0",
"axios": "^1.7.9",
"cookie": "^1.0.2",
"dialogs": "^2.0.1",
"electron-settings": "3.2.0",
"jquery": "^3.7.1",
Expand All @@ -44,10 +44,11 @@
"sanitize-filename": "^1.6.3"
},
"devDependencies": {
"electron": "^11.5.0",
"electron": "11.5.0",
"electron-builder": "^25.1.8",
"electron-reload": "^2.0.0-alpha.1",
"gh_deploy": "github:heliomarpm/gh_deploy"
"gh_deploy": "github:heliomarpm/gh_deploy",
"prettier": "^3.4.2"
},
"build": {
"appId": "com.faisalumair.udeler",
Expand Down

0 comments on commit 063bc3d

Please sign in to comment.