bug fix in communication in QR

helmholtz-analytics · Jan 21, 2025 · f49ffd1 · f49ffd1
1 parent d0ac81a
commit f49ffd1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/heat/core/linalg/pd.py b/heat/core/linalg/pd.py
@@ -110,8 +110,9 @@ def _in_place_qr_with_q_only(A: DNDarray, procs_to_merge: int = 2) -> None:
 
                 if A.comm.rank == i:
                     # orthogonalize the current block of columns by utilizing PyTorch QR
-                    A.larray, R = torch.linalg.qr(A.larray, mode="reduced")
-                    del R
+                    Q, R = torch.linalg.qr(A.larray, mode="reduced")
+                    A.larray = Q.contiguous()
+                    del Q, R
                     if i < nprocs - 1:
                         Q_buf = A.larray