Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version and list of contributors before releasing 1.5 #1685

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ClaudiaComito
Copy link
Contributor

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

Copy link
Contributor

Thank you for the PR!

@mtar mtar changed the base branch from main to release/1.5.x October 18, 2024 11:40
Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (8effbaa) to head (312632a).
Report is 3 commits behind head on release/1.5.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/1.5.x    #1685   +/-   ##
==============================================
  Coverage          92.12%   92.13%           
==============================================
  Files                 83       83           
  Lines              12171    12171           
==============================================
+ Hits               11213    11214    +1     
+ Misses               958      957    -1     
Flag Coverage Δ
unit 92.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine :)
Thanks at @ClaudiaComito 👍

@mrfh92 mrfh92 merged commit 8fda09b into release/1.5.x Oct 21, 2024
41 checks passed
@mrfh92 mrfh92 deleted the chores/prepare-release-1.5 branch October 21, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants