Only allow main loop to be controlled by platform, and remove some build options #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o control main loop
joshua-holmes
changed the title
emidoots
reviewed
Jan 12, 2025
| @@ -58,12 +58,20 @@ backend: Backend, | |||
| const MISSING_FEATURES_X11 = [_][]const u8{ "Resizing window", "Changing display mode", "VSync", "Setting window border/cursor" }; | |||
| const MISSING_FEATURES_WAYLAND = [_][]const u8{ "Resizing window", "Changing display mode", "VSync", "Setting window border/cursor" }; | |||
|
|
|||
| pub fn run(comptime on_each_update_fn: anytype, args_tuple: std.meta.ArgsTuple(@TypeOf(on_each_update_fn))) void { | |||
| while (@call(.auto, on_each_update_fn, args_tuple) catch false) {} | |||
There was a problem hiding this comment.
catch false here is sus, need to investigate better error handling for init of platforms
emidoots
reviewed
Jan 12, 2025
| @@ -33,6 +33,10 @@ pub const Context = struct { | |||
| window_id: mach.ObjectID, | |||
| }; | |||
|
|
|||
| pub fn run(comptime on_each_update_fn: anytype, args_tuple: std.meta.ArgsTuple(@TypeOf(on_each_update_fn))) void { | |||
| while (@call(.auto, on_each_update_fn, args_tuple) catch false) {} | |||
emidoots
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly makes these changes:
Remove
support_non_blockingoption because main loop will always be controlled by platform nowRemove
core_platformbuild option, since using-Dtarget=is the preferred method of selecting a build targetBy selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.