Improve performance of enqueueing tasks #946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Before enqueueing every task, the name of the queue is published to a Redis Set key (
base.AllQueues
).This is only used by the inspector for inspection/monitoring purposes (not for the processing of tasks).
Two consequences:
The issue #549 has more details about the impact on performance.
We've confirmed the figures in production.
Fixes #549
Rework of #550
Changes
base.AllQueues
once per workerNotes:
base.AllQueues
will still be retried until it worked.