Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(periodic_task_manager): Add RedisUniversalClient support #958

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

daixijun
Copy link
Contributor

@daixijun daixijun commented Nov 6, 2024

No description provided.

@kamikazechaser
Copy link
Collaborator

Duplicate of #742.

@daixijun
Copy link
Contributor Author

daixijun commented Nov 7, 2024

@kamikazechaser There is no duplication, and #742 does not implement RedisUniversalClient reuse in PTM

@kamikazechaser kamikazechaser reopened this Nov 7, 2024
@kamikazechaser
Copy link
Collaborator

kamikazechaser commented Nov 7, 2024

I see, that's right. Let me see if we can accommodate the same API in #742.

Copy link
Collaborator

@kamikazechaser kamikazechaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is no better way to change the API. Thanks.

@kamikazechaser kamikazechaser merged commit 12cbba4 into hibiken:master Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants