-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom Redis-like broker #976
base: master
Are you sure you want to change the base?
Conversation
08969e1
to
6dad2eb
Compare
There are some known issues for this PR:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #976 +/- ##
==========================================
- Coverage 67.13% 66.37% -0.77%
==========================================
Files 29 29
Lines 4300 5749 +1449
==========================================
+ Hits 2887 3816 +929
- Misses 1135 1652 +517
- Partials 278 281 +3 ☔ View full report in Codecov by Sentry. |
What redis-like broker is this? Is it one of the forks or is it one that implements the Redis wire protocol? |
The idea is good. Though we wouldn't land this in master immediately because:
|
It's a redis fork that maintained and operated by our infra team. The problem is that there's always a proxy in front of the redis instances, and the proxy doesn't support pubsub.
for the 1st& 2nd point, I'll try to upload a new patch to resolve them. |
Ah ok. It should generally be fine for now. I have started a discussion around this in #981. |
This PR decouples
Broker
interface from redis and allows creatingServer
andClient
directly from a broker instance. Which makes it possible for custom brokers.For exmaple: Redis from our infrastructure doesn't support pubsub. But I can inherit RDB and implement the pub/sub in another way to make asynq work without a huge amount of work.