Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#453] fixes for simplify plugin #455

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

laurentschoelens
Copy link
Collaborator

Fixes #453
Fixes highsource/jaxb2-basics#115

This PR will make simplifyPlugin respect globalBindings isSet / indexed properties

@laurentschoelens laurentschoelens added bug xjc-plugins Issue concerns basics plugins labels Nov 21, 2023
@laurentschoelens laurentschoelens added this to the 4.0.1 milestone Nov 21, 2023
@laurentschoelens laurentschoelens changed the title [#453] : fixes for simplify plugin [#453] fixes for simplify plugin Nov 21, 2023
Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrpav
Copy link
Collaborator

@laurentschoelens do we have a test that shows how to use the pluralization feature of the simplify plugin?

@laurentschoelens
Copy link
Collaborator Author

If I remember well, simplify01

@mattrpav mattrpav merged commit 6eb2982 into highsource:master Nov 22, 2023
3 checks passed
@mattrpav mattrpav deleted the jt-453 branch November 22, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug xjc-plugins Issue concerns basics plugins
Projects
None yet
2 participants