Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#340] base for no-jaxb mode #456

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[#340] base for no-jaxb mode #456

merged 1 commit into from
Nov 22, 2023

Conversation

laurentschoelens
Copy link
Collaborator

Fixes #340

Base RemoveXmlAnnotation plugin to remove all related XML annotations in generated classes.
Also add option to remove ObjectFactory class
Added test project

@laurentschoelens
[highsource#340] create a new option in annotate plugin to remove all…
99fa8b0 
… XML related annotations (with option to remove ObjectFactory)
@laurentschoelens laurentschoelens added enhancement annotate Issue concerns annotate plugin labels Nov 21, 2023
mattrpav
mattrpav approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrpav mattrpav merged commit c1f68c9 into highsource:master Nov 22, 2023
3 checks passed
@mattrpav mattrpav deleted the jt-340 branch November 22, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrpav mattrpav mattrpav approved these changes

Assignees

@mattrpav mattrpav

Labels
annotate Issue concerns annotate plugin enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a 'no-jaxb' mode of code generation
2 participants
@laurentschoelens @mattrpav