Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For clarinet deployments, can we improve error message in case of invalid mnemonic #1235

Closed
mefrem opened this issue Oct 27, 2023 · 0 comments · Fixed by #1286
Closed

For clarinet deployments, can we improve error message in case of invalid mnemonic #1235

mefrem opened this issue Oct 27, 2023 · 0 comments · Fixed by #1286
Labels
functional enhancement New feature or request

Comments

@mefrem
Copy link
Contributor

mefrem commented Oct 27, 2023

When a user deploys (or generates a deployment plan) without having pasted their mnemonic to either Testnet.toml or Mainnet.toml, the error message doesn't clearly indicate where Clarinet is reading the (incompatible/incorrect) mnemonic from.

Screen Shot 2023-10-27 at 2 54 38 PM

Could error message be updated to:

error: mnemonic (located in ./settings/Testnet.toml or ./settings/Mainnet.toml) for deploying address is invalid: mnemonic has a word count that is not a multiple of 6: 5
@mefrem mefrem added the functional enhancement New feature or request label Oct 27, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Oct 27, 2023
@mefrem mefrem changed the title For clarinet deployments, better error messages to point way to solution. For clarinet deployments, can we improve error message in case of invalid mnemonic Oct 27, 2023
@hugocaillard hugocaillard moved this from 🆕 New to 📋 Backlog in DevTools Nov 13, 2023
@lgalabru lgalabru mentioned this issue Dec 12, 2023
Merged
@hugocaillard hugocaillard linked a pull request Dec 13, 2023 that will close this issue
fix: polish deployment ux #1286
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in DevTools Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
functional enhancement New feature or request
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: polish deployment ux hirosystems/clarinet
2 participants
@hugocaillard @mefrem