Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: polish deployment ux #1286

Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: polish deployment ux #1286

merged 4 commits into from
Dec 12, 2023

Conversation

lgalabru
Copy link
Contributor

Address:
#1129
#1235

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (28a9e92) 41.85% compared to head (9ea5bdc) 41.83%.

Files Patch % Lines
components/clarinet-deployments/src/onchain/mod.rs 0.00% 51 Missing ⚠️
components/clarinet-cli/src/frontend/cli.rs 0.00% 7 Missing ⚠️
components/clarinet-cli/src/deployments/ui/ui.rs 0.00% 4 Missing ⚠️
components/clarinet-files/src/network_manifest.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1286      +/-   ##
===========================================
- Coverage    41.85%   41.83%   -0.02%     
===========================================
  Files           87       87              
  Lines        31369    31380      +11     
===========================================
  Hits         13128    13128              
- Misses       18241    18252      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hugocaillard
hugocaillard reviewed Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of remarks and questions

components/clarinet-deployments/src/onchain/mod.rs Outdated Show resolved Hide resolved
components/clarinet-cli/src/frontend/cli.rs Outdated Show resolved Hide resolved
components/clarinet-deployments/src/onchain/mod.rs Show resolved Hide resolved
components/clarinet-deployments/src/onchain/mod.rs Outdated Show resolved Hide resolved
hugocaillard
hugocaillard approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks Ludo

@hugocaillard hugocaillard enabled auto-merge (squash) December 12, 2023 20:53
@hugocaillard hugocaillard merged commit 47e6aac into develop Dec 12, 2023
19 checks passed
@hugocaillard hugocaillard deleted the fix/deployment-ux branch December 12, 2023 23:44
This was linked to issues Dec 13, 2023
Polish deployment UX/UI #1129
Closed
For clarinet deployments, can we improve error message in case of invalid mnemonic #1235
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugocaillard hugocaillard hugocaillard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For clarinet deployments, can we improve error message in case of invalid mnemonic Polish deployment UX/UI
2 participants
@lgalabru @hugocaillard