You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR focuses on removing the dependency on the resolve order when linking markdown files, where this would previously throw an "Error: [md] Cannot find story file" exception when the resolve order was out of sync, this PR now allows for out-of-resolve order linking.
Additional context
Whether this will impact performance on larger projects by looping through Markdown files once the watcher is complete.
Some changes had to be made to the tree.spec file for the tests to pass. Not sure if this is done correctly or if my tests are in the right place (markdown.spec)
What is the purpose of this pull request?
Bug fix
New Feature
Documentation update
Other
Before submitting the PR, please make sure you do the following
…files
This fixes the error when linking a markdown file to another markdown file that is higher than the resolve order of the parent.
histoire-dev#562
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error when linking a markdown file to another markdown file that is higher than the resolve order of the parent.
#562
Description
This PR focuses on removing the dependency on the resolve order when linking markdown files, where this would previously throw an "Error: [md] Cannot find story file" exception when the resolve order was out of sync, this PR now allows for out-of-resolve order linking.
Additional context
Whether this will impact performance on larger projects by looping through Markdown files once the watcher is complete.
Some changes had to be made to the
tree.specfile for the tests to pass. Not sure if this is done correctly or if my tests are in the right place (markdown.spec)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).