Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #exui-112: rediect to link expired login link page of state or nonce is stale #258

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

MunishSharmaHMCTS
Copy link
Contributor

@MunishSharmaHMCTS MunishSharmaHMCTS commented Dec 16, 2024

Jira link

https://tools.hmcts.net/jira/browse/EXUI-112

Change description

When a user visits the manage-case url for the first time they are immediately redirected to IDAM to login. If at that point the user bookmarks the IDAM url ("hmcts-access.service.gov.uk" in prod) then that bookmark will incude the State and Nonce values that XUI generated. Whenever a user revisits that bookmark they will experience the following flow:

Users visits bookmarked URL and see login page
User successfully logs in using IDAM
IDAM redirects back to XUI manage-case callback
XUI doesn't recognise the State and redirects back to IDAM with new State (and Nonce)
IDAM displays log in page
User successfully logs in using IDAM
IDAM redirects back to XUI manage-case callback
XUI displays cases
This ticket extends: EUI-4584

To understand the business impact, as part of the aforementioned ticket, we added logging into application insights, which can be seen [here|https://portal.azure.com/?whr=live.com#@HMCTS.NET/resource/subscriptions/8999dec3-0104-4a27-[…].Insights/components/xui-webapp-appinsights-prod/logs]

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@MunishSharmaHMCTS MunishSharmaHMCTS changed the title #exui-112: rediect to link expired login link page of state or nonce is stale fix: #exui-112: rediect to link expired login link page of state or nonce is stale Dec 16, 2024
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Jan 7, 2025

@Josh-HMCTS Josh-HMCTS merged commit f366fd2 into master Jan 7, 2025
7 checks passed
@Josh-HMCTS Josh-HMCTS deleted the EXUI-112-RedirectOnStaleStateOrNonce branch January 7, 2025 10:52
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
## [2.30.1](v2.30.0...v2.30.1) (2025-01-07)

### Bug Fixes

* #exui-112: rediect to link expired login link page of state or nonce is stale ([#258](#258)) ([f366fd2](f366fd2)), closes [#exui-112](https://github.com/hmcts/rpx-xui-node-lib/issues/exui-112) [#exui-112](https://github.com/hmcts/rpx-xui-node-lib/issues/exui-112)
Copy link

github-actions bot commented Jan 7, 2025

🎉 This PR is included in version 2.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants