ALS-7867 #62
Merged
ALS-7867 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deleted `DashboardDrawerList` record from the project. - Updated `DashboardDrawerController` to return a `List<DashboardDrawer>`. - Modified `DashboardDrawerService` to utilize a `List` instead of `DashboardDrawerList`. - Changed `DashboardDrawerRepository` to return `Optional<List<DashboardDrawer>>`. - Adjusted SQL join in `getDashboardDrawerRows` to use a LEFT JOIN.
- Updated `DashboardDrawerService` to use "default" layout as the fallback. - Simplified repository queries by removing materialized view checks. - Renamed methods in `DashboardDrawerRepository` for better clarity. - Removed `dashboard.layout.type` from `application-bdc.properties`. - Added unit and integration tests for `DashboardDrawerService`, `DashboardDrawerRepository`, and `DashboardDrawerController`.
TDeSain
commented
Dec 15, 2024
| @@ -13,7 +15,7 @@ public class DashboardDrawerController { | |||
| private DashboardDrawerService dashboardDrawerService; | |||
|
|
|||
| @GetMapping | |||
| public ResponseEntity<DashboardDrawerList> findAll() { | |||
| public ResponseEntity<List<DashboardDrawer>> findAll() { | |||
There was a problem hiding this comment.
Dumping DashboardDrawerList object in favor of using an actual list
TDeSain
commented
Dec 15, 2024
| String materializedViewSql = """ | ||
| select * from dictionary_db.dict.dataset_meta_materialized_view dmmv; | ||
| """; | ||
| public Optional<List<DashboardDrawer>> getDashboardDrawerRows() { |
There was a problem hiding this comment.
Debug log is too chatty. removing materialized views as they are not in use anyways.
TDeSain
commented
Dec 15, 2024
| @@ -15,7 +15,7 @@ public class DashboardDrawerService { | |||
| private final String dashboardLayout; | |||
|
|
|||
| @Autowired | |||
| public DashboardDrawerService(DashboardDrawerRepository repository, @Value("${dashboard.layout.type}") String dashboardLayout) { | |||
| public DashboardDrawerService(DashboardDrawerRepository repository, @Value("${dashboard.layout.type:default}") String dashboardLayout) { | |||
There was a problem hiding this comment.
Since there is no other implementation or requirements for other projects at the moment, will just make this the default layout. I do not like the value to be bdc for obvious reasons.
TDeSain
commented
Dec 15, 2024
| @@ -7,7 +7,6 @@ server.port=80 | |||
|
|
|||
| dashboard.enable.extra_details=true | |||
| dashboard.enable.bdc_hack=true | |||
TDeSain
commented
Dec 15, 2024
There was a problem hiding this comment.
Out of scope for this work. I wouldn't build a repository layer here. I would move the repository logic to the dataset repository.
Gcolon021
approved these changes
Jan 7, 2025
|
Tested in bdc dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.