[DRAFT] feat: tooltip component #561

CTAPCKPIM · 2023-12-28T18:47:35Z

Goal: add tooltip for FDM

Steps:

Detect place in the code
Update the code

Log:

Research time: 2 hrs

ETA: 1-4 hrs

vercel · 2023-12-28T18:47:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
holdex-venture-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 18, 2024 10:37am

CTAPCKPIM · 2023-12-28T19:55:12Z

https://momentjs.com/

CTAPCKPIM · 2023-12-28T20:09:34Z

https://momentjs.com/

Problem:

Don't update display of the date

CTAPCKPIM · 2023-12-28T20:53:28Z

@georgeciubotaru

I searched the place for an update of the component, let's merge, and in the next PR I finish

zolotokrylin

wrong PR title
why you even working on this issue? is it is not important!

zolotokrylin · 2023-12-29T06:35:45Z

There is no problem with the date. It is a fake and problem, and a solution is a waste of resources.
You need to work on something that brings value. If in doubt, ask leads in Discord about the problems to work on.

CTAPCKPIM · 2023-12-29T11:13:22Z

goal: redo the task

github-actions · 2023-12-29T12:16:57Z

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[DRAFT] feat: tooltip component". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - fix
 - feat
 - ci
 - chore
 - docs
 - test
 - release

CTAPCKPIM · 2023-12-29T13:03:55Z

@georgeciubotaru

Check pls

PR size is 4 hours, if possible, let's merge, and in the next PR I will correct the display tooltip e.t.

georgeciubotaru · 2024-01-03T09:01:56Z

src/lib/components/Tooltip/Tooltip.stories.svelte

@@ -0,0 +1,65 @@
+<script>


no need for this file

georgeciubotaru · 2024-01-03T09:02:04Z

src/lib/components/Chart/template.pug

+mixin information-circle
+  svg(width="16" height="16" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg")
+    circle(cx="12" cy="12" r="10" fill="lightblue")
+    text(
+      x="50%"
+      y="50%"
+      text-anchor="middle"
+      alignment-baseline="central"
+      font-size="14"
+      fill="white"
+    ) i


no in this scope

georgeciubotaru · 2024-01-03T09:02:18Z

.vscode/settings.json

@@ -2,7 +2,7 @@
  "editor.formatOnSave": true,
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": true
+    "source.fixAll.eslint": "explicit"


revert this

georgeciubotaru · 2024-01-03T09:04:08Z

src/lib/components/Tooltip/style.sass

+.tooltip
+    padding: calc(#{theme('spacing.6')} - 1px)
+    @apply block z-10 text-p2 text-gray-5 rounded-base-radius normal-case min-w-[250px] max-w-[346px] w-fit
+
+    &-arrow
+        position: absolute
+        height: 9px
+        width: 12px
+        @apply text-gray-70 stroke-gray-40
+
+        svg
+            position: relative
+            display: block
+            transform-origin: 50% 50%
+
+    &[data-placement^='top'] > &-arrow
+        bottom: -9px
+
+        svg
+            transform: rotate(0deg)
+
+    &[data-placement^='bottom'] > &-arrow
+        top: -9px
+
+        svg
+            transform: rotate(180deg)
+
+    &[data-placement^='left'] > &-arrow
+        right: -10.5px
+
+        svg
+            transform: rotate(-90deg)
+
+    &[data-placement^='right'] > &-arrow
+        left: -10.5px
+
+        svg
+            transform: rotate(90deg)


please check so the styles will match the Figma Design

@CTAPCKPIM The Figma UI https://www.figma.com/file/39MGGVIGQ1bL3FgVzuXEdC/Holdex?type=design&node-id=455-3579&mode=design&t=uMzOCWVu90AXDKxo-4

georgeciubotaru

see my comments.

CTAPCKPIM · 2024-01-10T11:19:01Z

@georgeciubotaru

Can you check and if need to correct my pls

CTAPCKPIM · 2024-01-11T16:02:03Z

@georgeciubotaru

Done, check pls

zolotokrylin · 2024-02-17T09:16:21Z

@georgeciubotaru

zolotokrylin · 2024-05-18T10:34:53Z

@georgeciubotaru

pr-time-tracker · 2024-05-18T10:35:41Z

@georgeciubotaru
@CTAPCKPIM
⚠️⚠️⚠️
You must submit the time spent on this PR.
⚠️⚠️⚠️

fear(ui): init

4824c8f

CTAPCKPIM self-assigned this Dec 28, 2023

feat: searching correct the place

5315c1c

vercel bot deployed to Preview December 28, 2023 19:17 View deployment

CTAPCKPIM requested a review from georgeciubotaru December 28, 2023 20:51

zolotokrylin requested changes Dec 29, 2023

View reviewed changes

feat: adding and removing comments

728cd06

vercel bot deployed to Preview December 29, 2023 11:13 View deployment

CTAPCKPIM changed the title ~~fix(ui): corrects the display of the date on price chart~~ feat(ui): implements tooltip for the FDM field Dec 29, 2023

georgeciubotaru changed the title ~~feat(ui): implements tooltip for the FDM field~~ [DRAFT] feat(ui): implements tooltip for the FDM field Dec 29, 2023

feat: adding logic for the tooltip

7d15bff

vercel bot deployed to Preview December 29, 2023 13:01 View deployment

CTAPCKPIM requested a review from zolotokrylin January 2, 2024 09:39

feat: implementing the tooltip component and place for him

6dece6b

CTAPCKPIM changed the title ~~[DRAFT] feat(ui): implements tooltip for the FDM field~~ [DRAFT] feat: implements tooltip component Jan 2, 2024

vercel bot deployed to Preview January 2, 2024 18:11 View deployment

feat: commiting the file

694df54

vercel bot deployed to Preview January 2, 2024 18:45 View deployment

georgeciubotaru reviewed Jan 3, 2024

View reviewed changes

georgeciubotaru requested changes Jan 3, 2024

View reviewed changes

georgeciubotaru changed the title ~~[DRAFT] feat: implements tooltip component~~ [DRAFT] feat: tooltip component Jan 3, 2024

chore: correcting settings.json and removing the code

5aeb2ca

vercel bot deployed to Preview January 10, 2024 10:17 View deployment

chore: removing the <script>

c220947

vercel bot deployed to Preview January 10, 2024 10:31 View deployment

faet: adding the selector for information-circle

a7769bf

vercel bot deployed to Preview January 10, 2024 11:18 View deployment

zolotokrylin requested a review from georgeciubotaru January 10, 2024 12:52

feat: correcting the style for tooltip box

d54e784

vercel bot deployed to Preview January 11, 2024 15:51 View deployment

feat: correcting the size of tghe arrow

dbd9312

vercel bot deployed to Preview January 11, 2024 15:54 View deployment

zolotokrylin requested a review from angelicawill May 18, 2024 10:35

Merge branch 'main' into issues/560

dbcac2f

vercel bot deployed to Preview May 18, 2024 10:37 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRAFT] feat: tooltip component #561

[DRAFT] feat: tooltip component #561

CTAPCKPIM commented Dec 28, 2023 •

edited

Loading

vercel bot commented Dec 28, 2023 •

edited

Loading

CTAPCKPIM commented Dec 28, 2023

CTAPCKPIM commented Dec 28, 2023

CTAPCKPIM commented Dec 28, 2023

zolotokrylin left a comment

zolotokrylin commented Dec 29, 2023

CTAPCKPIM commented Dec 29, 2023

github-actions bot commented Dec 29, 2023 •

edited

Loading

CTAPCKPIM commented Dec 29, 2023 •

edited

Loading

georgeciubotaru Jan 3, 2024

georgeciubotaru Jan 3, 2024

georgeciubotaru Jan 3, 2024 •

edited

Loading

georgeciubotaru Jan 3, 2024

georgeciubotaru Jan 10, 2024

georgeciubotaru left a comment

CTAPCKPIM commented Jan 10, 2024

CTAPCKPIM commented Jan 11, 2024

zolotokrylin commented Feb 17, 2024

zolotokrylin commented May 18, 2024

pr-time-tracker bot commented May 18, 2024 •

edited

Loading

[DRAFT] feat: tooltip component #561

Are you sure you want to change the base?

[DRAFT] feat: tooltip component #561

Conversation

CTAPCKPIM commented Dec 28, 2023 • edited Loading

vercel bot commented Dec 28, 2023 • edited Loading

CTAPCKPIM commented Dec 28, 2023

CTAPCKPIM commented Dec 28, 2023

CTAPCKPIM commented Dec 28, 2023

zolotokrylin left a comment

Choose a reason for hiding this comment

zolotokrylin commented Dec 29, 2023

CTAPCKPIM commented Dec 29, 2023

github-actions bot commented Dec 29, 2023 • edited Loading

CTAPCKPIM commented Dec 29, 2023 • edited Loading

georgeciubotaru Jan 3, 2024

Choose a reason for hiding this comment

georgeciubotaru Jan 3, 2024

Choose a reason for hiding this comment

georgeciubotaru Jan 3, 2024 • edited Loading

Choose a reason for hiding this comment

georgeciubotaru Jan 3, 2024

Choose a reason for hiding this comment

georgeciubotaru Jan 10, 2024

Choose a reason for hiding this comment

georgeciubotaru left a comment

Choose a reason for hiding this comment

CTAPCKPIM commented Jan 10, 2024

CTAPCKPIM commented Jan 11, 2024

zolotokrylin commented Feb 17, 2024

zolotokrylin commented May 18, 2024

pr-time-tracker bot commented May 18, 2024 • edited Loading

CTAPCKPIM commented Dec 28, 2023 •

edited

Loading

vercel bot commented Dec 28, 2023 •

edited

Loading

github-actions bot commented Dec 29, 2023 •

edited

Loading

CTAPCKPIM commented Dec 29, 2023 •

edited

Loading

georgeciubotaru Jan 3, 2024 •

edited

Loading

pr-time-tracker bot commented May 18, 2024 •

edited

Loading