Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(certificates): handle self signed certificates #1951

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Jan 14, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

image

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Jan 14, 2025
@Meierschlumpf Meierschlumpf self-assigned this Jan 14, 2025
Copy link

deepsource-io bot commented Jan 14, 2025

Here's the code health analysis summary for commits d4bb014..6ab57e5. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 1 occurence introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Jan 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.31% 8137 / 38174
🔵 Statements 21.31% 8137 / 38174
🔵 Functions 24.95% 297 / 1190
🔵 Branches 61.79% 896 / 1450
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/manage/tools/certificates/page.tsx 0% 0% 0% 0% 1-69
apps/nextjs/src/app/[locale]/manage/tools/certificates/_components/add-certificate.tsx 0% 0% 0% 0% 1-78
packages/api/src/root.ts 100% 100% 100% 100%
packages/api/src/router/certificates/certificate-router.ts 85% 100% 100% 85% 18-19, 25
packages/certificates/index.ts 0% 0% 0% 0% 1
packages/certificates/src/index.ts 0% 0% 0% 0% 1
packages/certificates/src/server.ts 13.2% 100% 0% 13.2% 8-11, 14-33, 36-42, 45-55, 58-67
packages/validation/src/certificates.ts 13.95% 100% 0% 13.95% 8-48
packages/validation/src/index.ts 100% 100% 100% 100%
Generated in workflow #4613 for commit 6ab57e5 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant