Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Remove reflection from tag view #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

GeorgeRNG
Copy link
Contributor

No description provided.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make this an Event instead? so showingTags can be in the other mixin

@GeorgeRNG
Copy link
Contributor Author

image
would be putting these events here be fine or should I put them in a static?

@homchom
Copy link
Owner

homchom commented Dec 17, 2023

  1. In general, they should definitely not be in the inject like that, because Fabric event registrations add a callback that is never unregistered. This Fabric event seems to be an exception in that it is reset after the screen is closed, and in fact I'm not sure if you can avoid using a second mixin here.
  2. As documented here, you should also not use Fabric events directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants