This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Fix styled text highlight crash #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2024 17:56
MiniMessageHighlighter::highlight may return a value that wasn't able to cast into a BuildableComponent. It may be better to move the check to the call-site in ExpressionHighlighting instead? Seems like more of an issue with MiniMessageHighlighter, though, because it's more specific to styled text.
homchom
suggested changes
Mar 23, 2024
…nt` to prevent possible future cast errors
homchom
approved these changes
Mar 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash occurred when writing
<hover:show_text:'>due to the expression being invalid and the fail-safe formatting not implementingBuildableComponentlike the syntax highlighter expects.resolves Issue
MiniMessageHighlighter::highlight's fail-safe returned aComponentLikethat could not be cast to aBuildableComponentbyExpressionHighlighting::highlightUncached, crashing the game. The fix changes that fail-safe to return aComponent(which implementsBuildableComponent).I figured it's better to fix the issue in the styled-text specific code because
MiniMessageHighlighterexpectsBuildableComponentsand nothing else seems to violate that.Fail-safe highlighting working properly:
