Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete misleading comments #3844

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Jan 21, 2025

This is not a problem because the IETF is the organization that manages RFCs for the Internet.

  • bun run format:fix && bun run lint:fix to format the code

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (3fba7a5) to head (cb1b22a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3844      +/-   ##
==========================================
+ Coverage   91.31%   91.36%   +0.04%     
==========================================
  Files         161      161              
  Lines       10240    10235       -5     
  Branches     2926     2860      -66     
==========================================
  Hits         9351     9351              
+ Misses        888      883       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryuapp
Copy link
Contributor

ryuapp commented Jan 21, 2025

The intention of that comments seems to be replace correct links when rfc6265bis is standardized.

Note: I'm adding link to latest draft in each comment, but should be updated to RFC link.
#2314 (comment)

So there's no need to delete the comments yet, we will have to wait for the right time.

@EdamAme-x
Copy link
Contributor Author

I see, I understand.
That interpretation seems to be correct.

@EdamAme-x EdamAme-x marked this pull request as draft January 21, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants