Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce properties.type for tokens #17

Open
gr2m opened this issue Oct 18, 2016 · 4 comments
Open

Enforce properties.type for tokens #17

gr2m opened this issue Oct 18, 2016 · 4 comments

Comments

@gr2m
Copy link
Member

gr2m commented Oct 18, 2016

properties.type must always be set and be of type string. Lowercase characters, numbers, - and _ only, must start with character.
@gr2m gr2m changed the title Enfore properties.type for tokens Enforce properties.type for tokens Oct 18, 2016
@Taekyoon
Copy link
Contributor

Taekyoon commented Nov 4, 2016

Can I try this one?

@gr2m
Copy link
Member Author

gr2m commented Nov 4, 2016

sure :) Let me know if you have any questions

@Taekyoon
Copy link
Contributor

Taekyoon commented Nov 9, 2016

@gr2m Do I have to make test code first? I think I need to do that before modifying the code

@gr2m
Copy link
Member Author

gr2m commented Nov 10, 2016

Yes, that’s what I’d do

@gr2m gr2m mentioned this issue Nov 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gr2m @Taekyoon