Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor splitting functions to more manageable functions #81

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Sujanadh
Copy link
Contributor

Updates:

There have been many changes to the clean code base.

  • Heavy functions such as split_by_sql and splitBySQL are broken down into smaller functions to make them manageable
  • Improve performance of splitting
  • Allow custom features without osm_id and tags during splitting using fmtm-splitter algorithm
  • Extract linear features when custom features are provided
  • If no extracts is provided, we retrieve both polygons and linestrings (buildings and road networks/rivers/...)

Outcome:

These changes have uplifted the performance of the fmtm-splitter, I tested using the whole Tokha municipality; it was successful without a timeout. Previously, it wasn't possible to split the whole Tokha municipality.

To Do:

@Sujanadh Sujanadh requested a review from spwoodcock January 17, 2025 11:42
@Sujanadh Sujanadh self-assigned this Jan 17, 2025
@Sujanadh Sujanadh marked this pull request as draft January 17, 2025 11:42
@github-actions github-actions bot added the enhancement New feature or request label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant