Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce toByteString API #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Introduce toByteString API #4

wants to merge 3 commits into from

Conversation

alissa-tung
Copy link

No description provided.

daleiz
daleiz requested changes Mar 16, 2022
View reviewed changes
Copy link

@daleiz daleiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not need add a wrappr for toLazyByteString, we should get a toByteString directly.

@alissa-tung
Copy link
Author

do not need add a wrappr for toLazyByteString, we should get a toByteString directly.

fixed

@alissa-tung alissa-tung requested a review from daleiz March 16, 2022 07:52
@alissa-tung alissa-tung mentioned this pull request Mar 16, 2022
Open
@alissa-tung alissa-tung changed the title Add strict wrapper for toLazyByteString Introduce toByteString API Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daleiz daleiz Awaiting requested review from daleiz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alissa-tung @daleiz