Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Poetry and Bumpversion #110

Merged
merged 25 commits into from
May 2, 2024

Conversation

ben9809
Copy link
Contributor

@ben9809 ben9809 commented Apr 25, 2024

Purpose

This pull request fixes problems related to documentation issues and refactors bumpversion.cfg

Approach

The new version of sphinx-rtd-theme has been updated to avoid any issues with the docs build.
The new .readthedocs.yml file complies with the poetry package manager.
The import was shortened to build the docs without any long module names.

Tests for New Behavior

None.

Checklist

None.

Learning

None

Copy link
Member

@Jackal08 Jackal08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need about a week and a bit to test this env variable and that the build works correctly.

- pip install poetry
post_install:
# Install dependencies
- VIRTUAL_ENV=$READTHEDOCS_VIRTUALENV_PATH poetry install --only docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an env variable? What should it be set to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$READTHEDOCS_VIRTUALENV_PATH is a predefined env variable set by Read the Docs in the build environment. It's the path to the virtual env used by 'Read the Docs' when building the project's documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- name: Publish to TestPyPI
env:
POETRY_PYPI_TOKEN_TESTPYPI: ${{ secrets.TEST_PYPI_API_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to setup and test this env variable + build. Will take me about a week.


- name: Publish to TestPyPI
env:
POETRY_PYPI_TOKEN_PYPI: ${{ secrets.PYPI_API_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to setup and test this env variable + build. Will take me about a week.

Copy link
Member

@Jackal08 Jackal08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you

@Jackal08 Jackal08 merged commit 3c7b55e into hudson-and-thames:develop May 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants