-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Poetry and Bumpversion #110
Setup Poetry and Bumpversion #110
Conversation
…to main and on Pypi to release the final version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need about a week and a bit to test this env variable and that the build works correctly.
- pip install poetry | ||
post_install: | ||
# Install dependencies | ||
- VIRTUAL_ENV=$READTHEDOCS_VIRTUALENV_PATH poetry install --only docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an env variable? What should it be set to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$READTHEDOCS_VIRTUALENV_PATH is a predefined env variable set by Read the Docs in the build environment. It's the path to the virtual env used by 'Read the Docs' when building the project's documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
- name: Publish to TestPyPI | ||
env: | ||
POETRY_PYPI_TOKEN_TESTPYPI: ${{ secrets.TEST_PYPI_API_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to setup and test this env variable + build. Will take me about a week.
|
||
- name: Publish to TestPyPI | ||
env: | ||
POETRY_PYPI_TOKEN_PYPI: ${{ secrets.PYPI_API_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to setup and test this env variable + build. Will take me about a week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, thank you
Purpose
This pull request fixes problems related to documentation issues and refactors bumpversion.cfg
Approach
The new version of sphinx-rtd-theme has been updated to avoid any issues with the docs build.
The new .readthedocs.yml file complies with the poetry package manager.
The import was shortened to build the docs without any long module names.
Tests for New Behavior
None.
Checklist
None.
Learning
None