Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Document Retrieval Goes Multilingual - llamaindex vdr-2b-multi-v1 #2584

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

Marplex
Copy link
Contributor

@Marplex Marplex commented Jan 9, 2025

Hey,
I'm adding a new blog post that talks about vdr-2b-multi-v1, a new multilingual visual document retrieval model.

The post contains images, they are pointing to what I believe will be the final url once the images are uploaded in the huggingface/documentation-images repo.

I saw other posts have html tags, but I have used standard markdown to include them. Is it ok? Will there be any problems when rendering it on the huggingface blog?

@logan-markewich
Copy link

@tomaarsen @pcuenca here's the blog post we were discussing on slack

Copy link
Contributor

@ariG23498 ariG23498 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely read. Thank you for your contribution.

Left some minor nits and queries.

_blog.yml Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the structure and agree with the suggestions from @ariG23498 and @tomaarsen. I'll proofread the content after they have been resolved.

_blog.yml Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
vdr-2b-multilingual.md Outdated Show resolved Hide resolved
@Marplex
Copy link
Contributor Author

Marplex commented Jan 10, 2025

Thanks for all your suggestions, very much appreciated :)
I have modified the blogpost and I think now it's better, what do you think?

@tomaarsen
Copy link
Member

Thanks @Marplex! If you want, feel free to resolve the review comments that you've addressed. I'll try to have another final look in a bit.

  • Tom Aarsen

Copy link
Member

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking excellent! Thanks for iterating with us 🤗

@tomaarsen tomaarsen dismissed ariG23498’s stale review January 10, 2025 16:51

The comments have been addressed nicely

@tomaarsen tomaarsen merged commit ad8e216 into huggingface:main Jan 10, 2025
1 check passed
@pcuenca pcuenca changed the title update latex formula Visual Document Retrieval Goes Multilingual - llamaindex vdr-2b-multi-v1 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants