Refactor ContrastiveDataset and ContrastiveDistillationDataset #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with bigger dataset
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
It also doesn't exist in 3.9 yet. https://docs.python.org/3/library/typing.html#typing.TypeAlias
…o refactor-contrds
|
Hello! I did a bit more tests, and I'm running into an issue: If I have a dataset with no positive pairs at all, then the generator will loop indefinitely, as it keeps going until it finds e.g. 3 positive pairs. This was also causing infinite loops via the
|
|
Fixed. |
|
Fixed the same problem when using sampling strategies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of ContrastiveDataset and ContrastiveDistillationDataset to generate pairs lazily. Also the trainer code is updated to create dataset from iterator. This targets how pairs are generated more motivation - #578
dataset = Dataset.from_generator(data_sampler.__iter__)this change allows to work with arbitrary big dataset (although the trade off is the cache on the disk managed by arrow dataset)This also targets the ContrastiveDistillationDataset bug in #578
fixes: #578