Skip to content

Commit

Permalink
renamed exporter span uploaded function
Browse files Browse the repository at this point in the history
  • Loading branch information
andreibratu committed Jan 7, 2025
1 parent 4658307 commit 8feeed5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/otel/exporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class HumanloopSpanExporter implements SpanExporter {
*
* @param spanId - The ID of the span that has been uploaded.
*/
private notifySpanUploaded(spanId: string) {
private markSpanCompleted(spanId: string) {
for (const [flowLogSpanId, flowChildrenSpanIds] of this.prerequisites) {
if (flowChildrenSpanIds.has(spanId)) {
flowChildrenSpanIds.delete(spanId);
Expand Down Expand Up @@ -161,7 +161,7 @@ export class HumanloopSpanExporter implements SpanExporter {
} catch (error) {
console.error(`Error exporting prompt: ${error}`);
}
this.notifySpanUploaded(span.spanContext().spanId);
this.markSpanCompleted(span.spanContext().spanId);
}

private async exportTool(span: ReadableSpan): Promise<void> {
Expand Down Expand Up @@ -190,7 +190,7 @@ export class HumanloopSpanExporter implements SpanExporter {
} catch (error) {
console.error(`Error exporting tool: ${error}`);
}
this.notifySpanUploaded(span.spanContext().spanId);
this.markSpanCompleted(span.spanContext().spanId);
}

private async exportFlow(span: ReadableSpan): Promise<void> {
Expand Down Expand Up @@ -233,6 +233,6 @@ export class HumanloopSpanExporter implements SpanExporter {
} catch (error) {
console.error("Error exporting flow: ", error, span.spanContext().spanId);
}
this.notifySpanUploaded(span.spanContext().spanId);
this.markSpanCompleted(span.spanContext().spanId);
}
}

0 comments on commit 8feeed5

Please sign in to comment.