Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added spellcheck action and dev instructions #16

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

daviroo
Copy link
Collaborator

@daviroo daviroo commented Sep 6, 2024

As per suggestion here #15 (comment)

@daviroo daviroo self-assigned this Sep 6, 2024
@daviroo daviroo mentioned this pull request Sep 6, 2024
3 tasks
@Extheoisah
Copy link
Member

Thanks for picking this up @daviroo
In the initialization step, one has to install npm the dep globally. Could we use something more native to rust and that wouldn't require global installation? Something we could add to the rust project and call it in ci e.g. https://github.com/crate-ci/typos
what do you think?

@daviroo
Copy link
Collaborator Author

daviroo commented Sep 6, 2024

Yeah that's probably better. I'm not very familiar with the workflows in Rust though. Do you know how to build that into the github actions easily? (it probably is easy I just haven't looked into it)

@Extheoisah
Copy link
Member

@daviroo I have switched it to the typos crate a4aeeb5

Copy link
Collaborator

@nully0x nully0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Extheoisah Extheoisah merged commit fd4f19a into main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants