feat: Complete challenge rewards #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviroo
force-pushed
the
complete-challenge-rewards
branch
from
fcd6934 to
4af92f1
Compare
Extheoisah
requested changes
Dec 5, 2024
| (repo) => sluggify(repo?.challenge?.title) === sluggify(challenge.title) | ||
| ); | ||
|
|
||
| const isCompleted = repository?.progress?.status === Status.Completed; |
There was a problem hiding this comment.
The Status.Completed in types folder is not the same as the one for progress status.
Suggested change
| const isCompleted = repository?.progress?.status === Status.Completed; | |
| const isCompleted = repository?.progress?.status === "completed"; |
| </p> | ||
| </section> | ||
| </div> | ||
| {isCompleted ? ( |
There was a problem hiding this comment.
This will always pay the user when they come to the challenge page after they've completed the challenge
There was a problem hiding this comment.
The user should be paid once only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested it with my blink account and it works. You need to define 3 env variables in vercel to get this to work:
BLINK_API_TOKENREWARD_IN_SATSBLINK_WALLET_IDI've DM'd you the values for these. It uses basic rate limiting for now to try and make it harder to exploit the endpoint.
The only part I haven't been able to test is if it works correctly with the course progress. You might need to fix that part up before merging.