-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TLS/mTLS options and configure the GraphQL HTTP service #7910
Open
pullurib
wants to merge
6
commits into
hyperledger:main
Choose a base branch
from
pullurib:graphql-tls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+659
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
macfarla
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, just would like to not be adding (test) code that references ommers
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
bgravenorst
added
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Dec 11, 2024
This pr is stale because it has been open for 30 days with no activity. |
@pullurib are you still working on this PR? |
Yes, @Gabriel-Trintinalia , I'll make review changes soon. |
…raphql/GraphQLHttpsServiceTest.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
The changes include the addition of command-line options to enable and configure TLS and mTLS for the GraphQL HTTP service.
Changes
New Command-Line Options:
--graphql-tls-enabled
: Enable TLS for the GraphQL HTTP service.--graphql-tls-keystore-file
: Path to the TLS keystore file.--graphql-tls-keystore-password-file
: Path to the file containing the password for the TLS keystore.--graphql-mtls-enabled
: Enable mTLS for the GraphQL HTTP service.--graphql-tls-truststore-file
: Path to the TLS truststore file.--graphql-tls-truststore-password-file
: Path to the file containing the password for the TLS truststore.Validation of Option Dependencies:
Testing
Documentation
CHANGELOG.md
to reflect the addition of new TLS options.Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests