remove ResetWriteBatch #141
Conversation
|
I am fine with the PR code-wise. But given that @denyeart and @bestbeforetoday are opposed to having this method, it makes sense to wait for their review. |
| func (h *Handler) handleStartWriteBatch(channelID string, txID string) { | ||
| if !h.usePeerWriteBatch { | ||
| return errors.New("peer does not support write batch") | ||
| return |
There was a problem hiding this comment.
I guess the intent here is that chaincode developer can call StartWriteBatch(), and it will work regardless of whether peer supports it or not.
If supported, requests will be batched.
If not supported, requests will be sent individually (consistent with existing behavior).
That seems like the right approach to allow for hybrid environments where some peers may support it, while other peers do not yet support it.
Did I get that right?
There was a problem hiding this comment.
It might be worth clarifying that behavior in the godoc for StartWriteBatch.
I notice that the existing godoc for StartWriteBatch reads:
StartWriteBatch enables a mode where all changes are not immediately forwarded to the feast
Perhaps feast was supposed to read peer?
There was a problem hiding this comment.
I guess the intent here is that chaincode developer can call StartWriteBatch(), and it will work regardless of whether peer supports it or not. If supported, requests will be batched. If not supported, requests will be sent individually (consistent with existing behavior).
That seems like the right approach to allow for hybrid environments where some peers may support it, while other peers do not yet support it.
Did I get that right?
Yeah. That's right.
There was a problem hiding this comment.
It might be worth clarifying that behavior in the godoc for StartWriteBatch.
I notice that the existing godoc for StartWriteBatch reads:
StartWriteBatch enables a mode where all changes are not immediately forwarded to the feast
Perhaps feast was supposed to read peer?
That's right. Thank you for finding out. I fixed it.
Signed-off-by: Fedor Partanskiy <[email protected]>
pfi79
force-pushed
the
batch-operations
branch
from
d7ea266 to
838571a
Compare
hyperledger/fabric#5086