Separate "define" and "publish" for contract APIs, and allow deleting unpublished APIs #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer,
shorsher and
nickgaski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1322 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 312 314 +2
Lines 21266 21418 +152
===========================================
+ Hits 21266 21415 +149
- Misses 0 3 +3
|
awrichar
commented
May 30, 2023
| } else if existing != nil { | ||
| return wrapSendError(i18n.NewError(ctx, coremsgs.MsgNetworkNameExists)) | ||
| } | ||
|
|
There was a problem hiding this comment.
Just realized that I missed a check for the interface to have been published first (ie need to add this one here too).
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
|
Added one new commit to fix this, and rebased after merging all pre-requisite PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for #1220
In a chain with #1279 and #1321