Apply changes from the cookiecutter #6929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
ruff-linter
branch
from
d1d22ed to
f896f45
Compare
marcospri
commented
Dec 31, 2024
| @@ -5,7 +5,7 @@ groups: | |||
| eslint: | |||
| patterns: | |||
| - 'eslint*' | |||
| - '@typescript-eslint/*' | |||
| - 'typescript-eslint' | |||
There was a problem hiding this comment.
Include this change in the includes
| @@ -37,6 +39,13 @@ You should also see an "Insecure content blocked" icon in the top right of the l | |||
|
|
|||
| Click on the <samp>Load unsafe scripts</samp> link and the app should load successfully. | |||
|
|
|||
| ### Localhost alias | |||
There was a problem hiding this comment.
Moving this to the includes
| @@ -1,33 +0,0 @@ | |||
| [tool.mypy] | |||
There was a problem hiding this comment.
This are all mypy's. They are part of the template now.
| @@ -115,7 +115,7 @@ jobs: | |||
| - name: Upload coverage file | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: coverage | |||
| name: coverage-python${{ matrix.python-version}} | |||
There was a problem hiding this comment.
Change from the template.
| @@ -42,7 +44,7 @@ def delete(engine: Engine) -> None: | |||
| """Delete any existing DB tables.""" | |||
|
|
|||
| try: | |||
| from lms.db import pre_delete # noqa: PLC0415 | |||
| from lms.db import pre_delete | |||
There was a problem hiding this comment.
Moved the noqa to the top, simplifies the template for now.
| @@ -10,32 +10,6 @@ filterwarnings = [ | |||
| "ignore:^'cgi' is deprecated and slated for removal in Python 3\\.13$:DeprecationWarning:webob", | |||
| ] | |||
|
|
|||
| [tool.coverage.run] | |||
|
|
||
| [tool.mypy] | ||
| python_version = 3.11 | ||
| allow_untyped_globals = true |
There was a problem hiding this comment.
This defaults are the template ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the changes over: hypothesis/cookiecutters#188