snap: snap only to windows floating over top of fullscreen window if one exists #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myQwil
changed the title
vaxerski
reviewed
Dec 29, 2024
myQwil
force-pushed
the
snap_fullscreen
branch
from
da4c34d to
d7f1d94
Compare
myQwil
changed the title
myQwil
changed the title
|
what if the window is above the fullscreen one thoigh? |
|
Would |
myQwil
force-pushed
the
snap_fullscreen
branch
from
d7f1d94 to
d418770
Compare
myQwil
changed the title
|
yes |
vaxerski
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Addresses #8647
If the dragging window is pinned, and the workspace of the dragging window has a fullscreen window, it won't snap to any windows that might be hidden underneath the fullscreen window.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Nope
Is it ready for merging, or does it need work?
Ready for merging