Add option to show slaves on left in master layout center orientation #8940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jan 3, 2025
|
Why only left or right.. why not top and bottom? |
Couse, it doesn't only set the layout used if slave_counter_for_center_master > 2. It also makes windows spawn from left to right instead of right to left when masters are centered, Can't do that in 1 property, since we can't decide where should slaves spawn if we are using top or bottom. |
Zetta1Reid0
force-pushed
the
main
branch
2 times, most recently
from
9f18a46 to
9d94f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to use right master orientation when slave_count_for_center_master > 2 ,
also makes windows tile to left side first then to the right side when option is set.
Is it ready for merging, or does it need work?
I think it should e finished. I tested it, everything works as expected.