-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: window rounding % #9015
base: main
Are you sure you want to change the base?
feat: window rounding % #9015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am generally unsure if this is a good idea, like, at all. What is the usecase? This will just look stupid.
You are also allowed to write a script that does this for you by dispatching setprop...
just was looking for unresolved issues with the |
I don't close feature requests unless really dumb, but I fail to see the point here. |
so now we have some dumb feature request, not such dumb pull request, and u can feel free to close both :D i dont mind. it was a sleepless night and I had nothing to do |
Hey! Thank you so much for this! I believe that a window rounding percentage would be good for simillar scaling for every window. Ex: 10px on a 15 px window is absurd, while 10px on a 512px window is natural. Thanks, PS: the work is already done (tysm to @Truenya), so dumb or not, wouldn't merging be the best choice of action? |
tbh I'd be more in favor of a plugin for this... |
Okay! Thanks, |
Describe your PR, what does it fix/add?
#8726
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
value more than 1% looks absolutely unuseful. it would probably be a good idea to scale it by 0.01 or something like that.
But it is possible to use fractional percent values like 0.42%
hyprwm/hyprland-wiki#939
Is it ready for merging, or does it need work?
ready for merging