Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary sixel sequence wrapper. #146

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

j4james
Copy link
Contributor

@j4james j4james commented Jan 4, 2025

The sixel_encode function will already generate a complete Sixel
sequence, so there is no need to wrap that with an additional sequence
introducer and terminator, and doing so can cause problems on some
terminals.

@j4james
Copy link
Contributor Author

j4james commented Jan 4, 2025

I've tested this on 16 different Sixel terminals, and I've confirmed that it still works as well as before (and in some cases better) than without the PR applied.

Quite a few terminals (MLTerm, St, Yaft, RLogin) had glitches in the first few scanlines of the image which are no longer apparent. The Rxvt sixel fork just used to spew the entire sequence contents as text, and that's now fixed. And as I mentioned in #145, Windows Terminal would previously fill the background with a random color, and that's no longer the case.

@hzeller hzeller merged commit e1e3dad into hzeller:main Jan 4, 2025
7 checks passed
@hzeller
Copy link
Owner

hzeller commented Jan 4, 2025

Thanks!

@j4james j4james deleted the remove-sixel-wrapper branch January 4, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants