Merge pull request #74 from messerm/messerm/fixI18nKey

Fix support for single quotes
i18next · Feb 28, 2018 · 7f2b97a · 7f2b97a
2 parents c5e1242 + 4ef36dc
commit 7f2b97a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/parser.js b/src/parser.js
@@ -191,7 +191,7 @@ const transformOptions = (options) => {
 };
 
 const getStringFromAttribute = (attr) => {
-    if (attr[0] === '"' || attr[1] === '\'') {
+    if (attr[0] === '"' || attr[0] === '\'') {
         return attr.slice(1, -1);
     }
     throw new Error('attribute value must be a string');

diff --git a/test/fixtures/app.jsx b/test/fixtures/app.jsx
@@ -1,6 +1,7 @@
 const mycomp = () => (
     <React.Fragment>
         <Trans i18nKey="key1">Key 1 default</Trans>
+        <Trans i18nKey='key1SingleQuote'>Key must be key1SingleQuote</Trans>
         <Trans i18nKey="key2">
             Key 2
             default value

diff --git a/test/parser.js b/test/parser.js
@@ -115,6 +115,7 @@ test('Parse Trans component #1', (t) => {
         en: {
             translation: {
                 "key1": "Key 1 default",
+                "key1SingleQuote": "Key must be key1SingleQuote",
                 "key2": "Key 2 default value",
                 "key3": "This is a <1>test</1>",
                 "key4": "You have <1>{{count}}</1> apples",
@@ -152,6 +153,7 @@ test('Parse Trans component #2', (t) => {
         en: {
             translation: {
                 "key1": "Key 1 default",
+                "key1SingleQuote": "Key must be key1SingleQuote",
                 "key2": "Key 2 default value",
                 "key3": "This is a <1>test</1>",
                 "key4": "You have <1>{{count}}</1> apples",