-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split grid factor #217
Draft
grazwegian
wants to merge
25
commits into
i4Ds:master
Choose a base branch
from
grazwegian:split-grid-factor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Split grid factor #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* i4ds: Fix elut correction factor (i4Ds#178)
* i4ds: Check online version of ELUT and science energy channel configurations. (i4Ds#175)
* i4ds: Imaging pipeline improvements (i4Ds#176)
* i4ds: Imaging pipeline improvements (i4Ds#176)
* i4ds: Initial release of basic routines for downloading L2 AUX ephemeris files given a date and L1 science data fits files given a UID. (i4Ds#189) Fixed bug in the estimation of the total number of bkg counts (i4Ds#186) stx_livetime_fraction: update of default eta value using empirical high trigger rate data (i4Ds#188) Energy calibration improvement (i4Ds#183) Call lightcurve without generating FITS files (i4Ds#181) Respect shift_duration if file is "possibly summed on board". (i4Ds#180) Clarify flare_location coordinates (i4Ds#169) # Conflicts: # stix/dbase/detector/elut_index.csv
* i4ds: Initial release of basic routines for downloading L2 AUX ephemeris files given a date and L1 science data fits files given a UID. (i4Ds#189) Fixed bug in the estimation of the total number of bkg counts (i4Ds#186) stx_livetime_fraction: update of default eta value using empirical high trigger rate data (i4Ds#188) Energy calibration improvement (i4Ds#183) Call lightcurve without generating FITS files (i4Ds#181) Respect shift_duration if file is "possibly summed on board". (i4Ds#180) Clarify flare_location coordinates (i4Ds#169) # Conflicts: # stix/dbase/detector/elut_index.csv
* i4ds: Some Improvement in aspect processing (i4Ds#179)
* i4ds: Fixed bug in selection of energy indices of pixel data matrix (i4Ds#185)
* i4ds: preparing a new release stx_subc_transmission: Improved accuracy of message displayed if simple_transm keyword is set. Update by Massa, P. - use simplified version of the subcollimator transmission for imaging (temporary solution) changed default behaviour of flux keyword Improvements to transmission following suggestions from @paolomassa. Value of flux = 1 passed through from stx_fsw_sd_spectrogram2ospex. Additional description of calculation of linear attenuation coefficient in stx_subc_transmission. stx_write_ospex_fits: fix grid factor recording in FITS file for srm file stx_write_ospex_fits: fix grid factor recording in FITS file stx_subc_transmission: added default to calculate low energy approximation if no input photon energies are passed fix calculation for single included grid fix grid factor rebinning remove unneeded lines remove commented lines Fix ELUT correction for background data Fix elut correction factor Updated grid transmission to include transparency and corner cutting for pure Tungsten grids following Recipe for STIX Flux and Amplitude Calibration (8-Nov 2022 gh). Changes to grid factor to include tungsten transmission
* i4ds: Bugfix release stx_read_fits : uncommented call to mrdfits to prevent compilation issue when getting version number
* main: Bugfix release stx_read_fits : uncommented call to mrdfits to prevent compilation issue when getting version number preparing a new release stx_subc_transmission: Improved accuracy of message displayed if simple_transm keyword is set. Update by Massa, P. - use simplified version of the subcollimator transmission for imaging (temporary solution) changed default behaviour of flux keyword Improvements to transmission following suggestions from @paolomassa. Value of flux = 1 passed through from stx_fsw_sd_spectrogram2ospex. Additional description of calculation of linear attenuation coefficient in stx_subc_transmission. stx_write_ospex_fits: fix grid factor recording in FITS file for srm file stx_write_ospex_fits: fix grid factor recording in FITS file stx_subc_transmission: added default to calculate low energy approximation if no input photon energies are passed fix calculation for single included grid fix grid factor rebinning remove unneeded lines remove commented lines Fix ELUT correction for background data Fix elut correction factor Updated grid transmission to include transparency and corner cutting for pure Tungsten grids following Recipe for STIX Flux and Amplitude Calibration (8-Nov 2022 gh). Changes to grid factor to include tungsten transmission
* i4ds: fixed i4Ds#205 (fix by Dominic Zarro) Update VERSION.txt Update stx_imaging_demo (i4Ds#203) Remove unused keyword from structure Add IDL_STARTUP file to stix/setup which will be run every time SSWIDL is started. Currently this only calls stx_check_config_files (i4Ds#196) Skip ELUT (i4Ds#182)
* main: fixed i4Ds#205 (fix by Dominic Zarro) Update VERSION.txt Update stx_imaging_demo (i4Ds#203) Remove unused keyword from structure Add IDL_STARTUP file to stix/setup which will be run every time SSWIDL is started. Currently this only calls stx_check_config_files (i4Ds#196) Skip ELUT (i4Ds#182)
* i4ds: Spectroscopy demo fix (i4Ds#207)
* main: Spectroscopy demo fix (i4Ds#207)
* i4ds: Lightcurve demo fix (i4Ds#208)
* i4ds: Lightcurve demo fix (i4Ds#208)
* i4ds: Update VERSION.txt
* main: Update VERSION.txt
* i4ds: Add DOI to readme (i4Ds#211)
Nearly ready needs testing @grazwegian will try to update soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deal with the energy dependence of the grid transmission the grid factor was expanded from a single value to an array and incorporated into the DRM. However this causes inconsistencies for products which do not go through the DRM. This splits the grid factor into an opaque component which is included as the grid factor was previously and an energy dependent correction which is incorporated into the DRM.