-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed some unnecessary preset parameters for FW #2287
base: master
Are you sure you want to change the base?
Conversation
Maybe instead of removing these, just adjust the airplane without a tail values as bredoven recommendations? We can look into removing this later, with more time for testing. |
If the controller now controls velocity and not position, I think the difference in wing load and pitch authority should not make a difference between them anymore. What is breadoven's recommendation? Could not see that in the 2 threads I follow. If they still act differently then yes I can add them back in with slightly different values. |
I don't see any reason why the velocity altitude control would affect the xy position control so these values should be left unchanged. |
@breadoven I removed the xy presets in that go as well since I noticed that somewhere in the 7.0 or 7.1 phase the value for flying wings with no tail was too low. I planned to change/remove them for a while and just remembered so I removed them now. |
Put settings back in with recommended defaults
I have restored the settings and just changed the defaults slightly based on the recommendations. |
This missed the train for 8.0. What is the concensus? Is it still needed? |
Not mandatory |
Removed some Preset values for Fixed wings due to FW changes that will be good on defaults.
Comes along with iNavFlight/inav#10541