Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Update Surface documentation #1219

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

adamhock
Copy link
Contributor

Changes

Testing

N/A

Docs

N/A

@adamhock adamhock requested a review from a team as a code owner April 20, 2023 01:58
@adamhock adamhock requested review from a team, gretanausedaite and LostABike and removed request for a team April 20, 2023 01:58
@adamhock adamhock changed the title initial commit website: Update Surface documentation Apr 20, 2023
@adamhock adamhock self-assigned this Apr 20, 2023
Copy link
Contributor

@gretanausedaite gretanausedaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.


Elevation is measured as the distance between surfaces.

<LiveExample src='Surface.elevation.tsx' truncate={false}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove truncate prop to allow truncation on this example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@adamhock adamhock added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 673e50d Apr 20, 2023
@adamhock adamhock deleted the adam/surface-documentation branch April 20, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants