-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail test-image-openj9 target when java -version fails #639
Conversation
Does this repo still need to require commit sign-off for some reason? I suspect that it doesn't, and that the failing check is a holdover |
If you have good a reason that the check should be removed, then please capture it in an issue. Until we have agreement to remove the signed-off-by check, please update the commit message. |
8030b49
to
ad056dd
Compare
Updated
Opened #644 |
ad056dd
to
20a8620
Compare
Updated the copyright header |
20a8620
to
ee9fc03
Compare
Changed |
Do you intend to offer equivalent changes for other jdk versions (11, 17, 19, 20, next)? |
Oh, thanks, good catch! I should, yes. When I built various versions on my local machine under |
There a 'next' extensions repo? I don't see one. |
https://github.com/ibmruntimes/openj9-openjdk-jdk (without the numeric suffix). |
ee9fc03
to
48f2511
Compare
Updated this PR so that the changes are consistent with those for later JDK versions |
Previously, the exit status would come from tee, which succeeded.
48f2511
to
0b414e4
Compare
Added quotes for consistency |
Jenkins compile zlinux jdk8 |
Previously, the exit status would come from
tee
, which succeeded.