I went a little bit ahead of myself... #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 28, 2019 09:47
That way, we have nice error messages instead of panics if they get the patterns wrong.
Not that it would matter, but IO is really costly if not done correctly. Ideally, one buffers separately, if it ever becomes an issue.
There error handling could easily be added.
ghost
commented
May 28, 2019
| pattern, | ||
| }) | ||
| }) | ||
| .collect::<Result<_, _>>()?, |
There was a problem hiding this comment.
This is one of the best tricks in the book. Collect into a Result<_, _>, which is useful if your iterators produces Result<T, _>. That way, if there is an error, you will get it into the top level. You get a pristine Vec<T>.
added 8 commits
May 28, 2019 13:50
It shows that `.as_ref()` is something the checker doesn't really see through, leading to issues which should be none. Reminder to myself: use 'ref' based destructuring preferably over things like 'Option::as_ref()`.
dodadoa
reviewed
Oct 20, 2021
| human-panic = "1.0.1" | ||
| lazy_static = "1.3.0" |
There was a problem hiding this comment.
maybe you can use OnceCell instead of lazy_static I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and thought I could make it a nice practice to write it as idiomatically as possible.
In the process, I changed a lot, but I believe to the better.
I hope you find these changes useful, in any case it was fun writing some Rust again :).