Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PowerPC #76

Merged
merged 9 commits into from
Nov 9, 2024
Merged

Fix PowerPC #76

merged 9 commits into from
Nov 9, 2024

Conversation

Fancy2209
Copy link
Contributor

@Fancy2209 Fancy2209 commented Nov 9, 2024 •
edited
Loading

Tested on a Wii running Wii-Linux ArchPOWER.
Sample output from testparse
output.wii.txt

@flibitijibibo
Copy link
Collaborator

flibitijibibo commented Nov 9, 2024 •
edited
Loading

Conflicted this ever so slightly:

14c62c0
04926f5

Now you can check #ifdef MOJOSHADER_BIG_ENDIAN in effects.c, and the internal.h changes can be mostly discarded except for maybe the ppc asm path.

flibitijibibo
flibitijibibo approved these changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor cleanup I can push

mojoshader_effects.c Outdated Show resolved Hide resolved
mojoshader_effects.c Outdated Show resolved Hide resolved
mojoshader_internal.h Outdated Show resolved Hide resolved
flibitijibibo
flibitijibibo reviewed Nov 9, 2024
View reviewed changes
mojoshader_internal.h Outdated Show resolved Hide resolved
@flibitijibibo flibitijibibo merged commit 7e569cc into icculus:main Nov 9, 2024
3 checks passed
@Fancy2209 Fancy2209 mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flibitijibibo flibitijibibo flibitijibibo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fancy2209 @flibitijibibo