Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up existing config.ini if required to remove obsolete entries. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

borntohonk
Copy link

Cleans up config.ini to remove old obsolete entries such as "es7_FW18-19" which can confuse the end-users.

@ITotalJustice
Copy link

please don't merge this. just use minini to remove entries. this can be reduced down to a couple lines of code.

@borntohonk
Copy link
Author

please don't merge this. just use minini to remove entries. this can be reduced down to a couple lines of code.

Think of this as the step-father of your child disciplining it differently in your absence.

If you want it raised right, feel free to step up.

@ITotalJustice
Copy link

I am not sure what you mean by that comment, I'll choose to ignore it.

There's 2 ways to go about this.

  • delete the config after all entries are read, then simply write them back to file.
  • use ini_puts with null as the value to delete a key.

Personally I wouldn't do anything. If users are getting confused about old entries in the file then that's on them. It's not like the overlay displays them.

@borntohonk
Copy link
Author

I am not sure what you mean by that comment, I'll choose to ignore it.

Take ownership of your former project, and make the changes the way you want it. Or watch from afar as it goes through a gradual process of perceived bloat/enshitification.

In an abstract symbolic way, if you don't like the way someone else is raising your child that you have disowned, then just step up, make amends and take responsibility.

@ITotalJustice
Copy link

I mean, everyone has done a great job of maintaining this. The overlapping buffer fix is mostly correct for example 😉

The changes in this commit are a bit too drastic and bug prone imo, especially for the problem it's trying to solve. I am simply suggesting an alternative way of solving said problem.

Merge it if you like, I just don't think it's a good proposed fix, no offence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants