Group by discrete variables #405
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -276,41 +276,41 @@ void AnalysisModule::calculate_population_statistics(RuntimeContext &context, | |||
| auto current_time = static_cast<unsigned int>(context.time_now()); | |||
| for (const auto &entity : context.population()) { | |||
| auto age = entity.age; | |||
| auto gender = entity.gender; | |||
| auto over_18 = entity.over_18; | |||
There was a problem hiding this comment.
warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
| auto over_18 = entity.over_18; | |
| auto over_18 = entity.over_18(); |
| series(gender, "deaths").at(age)++; | ||
| auto expcted_life = definition_.life_expectancy().at(context.time_now(), gender); | ||
| series(gender, "yll").at(age) += std::max(expcted_life - age, 0.0f) * DALY_UNITS; | ||
| series(over_18, "deaths").at(age)++; |
There was a problem hiding this comment.
warning: no matching function for call to object of type 'hgps::DataSeries' [clang-diagnostic-error]
series(over_18, "deaths").at(age)++;
^Additional context
src/HealthGPS/data_series.h:29: candidate function not viable: no known conversion from 'bool' to 'core::Gender' for 1st argument
std::vector<double> &operator()(core::Gender gender, const std::string &key);
^| auto expcted_life = definition_.life_expectancy().at(context.time_now(), gender); | ||
| series(gender, "yll").at(age) += std::max(expcted_life - age, 0.0f) * DALY_UNITS; | ||
| series(over_18, "deaths").at(age)++; | ||
| auto expcted_life = definition_.life_expectancy().at(context.time_now(), over_18); |
There was a problem hiding this comment.
warning: no matching member function for call to 'at' [clang-diagnostic-error]
auto expcted_life = definition_.life_expectancy().at(context.time_now(), over_18);
^Additional context
src/HealthGPS/gender_table.h:72: candidate function not viable: no known conversion from 'bool' to 'const core::Gender' for 2nd argument
const TYPE &at(const ROW row, const core::Gender gender) const {
^src/HealthGPS/gender_table.h:63: candidate function not viable: 'this' argument has type 'const GenderTable<int, float>', but method is not marked const
TYPE &at(const ROW row, const core::Gender gender) {
^| series(gender, "yll").at(age) += std::max(expcted_life - age, 0.0f) * DALY_UNITS; | ||
| series(over_18, "deaths").at(age)++; | ||
| auto expcted_life = definition_.life_expectancy().at(context.time_now(), over_18); | ||
| series(over_18, "yll").at(age) += std::max(expcted_life - age, 0.0f) * DALY_UNITS; |
There was a problem hiding this comment.
warning: no matching function for call to object of type 'hgps::DataSeries' [clang-diagnostic-error]
series(over_18, "yll").at(age) += std::max(expcted_life - age, 0.0f) * DALY_UNITS;
^Additional context
src/HealthGPS/data_series.h:29: candidate function not viable: no known conversion from 'bool' to 'core::Gender' for 1st argument
std::vector<double> &operator()(core::Gender gender, const std::string &key);
^| } | ||
|
|
||
| if (entity.has_emigrated() && entity.time_of_migration() == current_time) { | ||
| series(gender, "migrations").at(age)++; | ||
| series(over_18, "migrations").at(age)++; |
There was a problem hiding this comment.
warning: no matching function for call to object of type 'hgps::DataSeries' [clang-diagnostic-error]
series(over_18, "migrations").at(age)++;
^Additional context
src/HealthGPS/data_series.h:29: candidate function not viable: no known conversion from 'bool' to 'core::Gender' for 1st argument
std::vector<double> &operator()(core::Gender gender, const std::string &key);
^|
|
||
| for (const auto &factor : context.mapping().entries()) { | ||
| series(gender, factor.key().to_string()).at(age) += | ||
| series(over_18, factor.key().to_string()).at(age) += |
There was a problem hiding this comment.
warning: no matching function for call to object of type 'hgps::DataSeries' [clang-diagnostic-error]
series(over_18, factor.key().to_string()).at(age) +=
^Additional context
src/HealthGPS/data_series.h:29: candidate function not viable: no known conversion from 'bool' to 'core::Gender' for 1st argument
std::vector<double> &operator()(core::Gender gender, const std::string &key);
^| entity.get_risk_factor_value(factor.key()); | ||
| } | ||
|
|
||
| for (const auto &[disease_name, disease_state] : entity.diseases) { | ||
| if (disease_state.status == DiseaseStatus::active) { | ||
| series(gender, "prevalence_" + disease_name.to_string()).at(age)++; | ||
| series(over_18, "prevalence_" + disease_name.to_string()).at(age)++; |
There was a problem hiding this comment.
warning: no matching function for call to object of type 'hgps::DataSeries' [clang-diagnostic-error]
series(over_18, "prevalence_" + disease_name.to_string()).at(age)++;
^Additional context
src/HealthGPS/data_series.h:29: candidate function not viable: no known conversion from 'bool' to 'core::Gender' for 1st argument
std::vector<double> &operator()(core::Gender gender, const std::string &key);
^| if (disease_state.start_time == context.time_now()) { | ||
| series(gender, "incidence_" + disease_name.to_string()).at(age)++; | ||
| series(over_18, "incidence_" + disease_name.to_string()).at(age)++; |
There was a problem hiding this comment.
warning: no matching function for call to object of type 'hgps::DataSeries' [clang-diagnostic-error]
series(over_18, "incidence_" + disease_name.to_string()).at(age)++;
^Additional context
src/HealthGPS/data_series.h:29: candidate function not viable: no known conversion from 'bool' to 'core::Gender' for 1st argument
std::vector<double> &operator()(core::Gender gender, const std::string &key);
^| } | ||
| } | ||
| } | ||
|
|
||
| auto dw = calculate_disability_weight(entity); | ||
| series(gender, "disability_weight").at(age) += dw; | ||
| series(gender, "yld").at(age) += (dw * DALY_UNITS); | ||
| series(over_18, "disability_weight").at(age) += dw; |
There was a problem hiding this comment.
warning: no matching function for call to object of type 'hgps::DataSeries' [clang-diagnostic-error]
series(over_18, "disability_weight").at(age) += dw;
^Additional context
src/HealthGPS/data_series.h:29: candidate function not viable: no known conversion from 'bool' to 'core::Gender' for 1st argument
std::vector<double> &operator()(core::Gender gender, const std::string &key);
^| series(gender, "disability_weight").at(age) += dw; | ||
| series(gender, "yld").at(age) += (dw * DALY_UNITS); | ||
| series(over_18, "disability_weight").at(age) += dw; | ||
| series(over_18, "yld").at(age) += (dw * DALY_UNITS); |
There was a problem hiding this comment.
warning: no matching function for call to object of type 'hgps::DataSeries' [clang-diagnostic-error]
series(over_18, "yld").at(age) += (dw * DALY_UNITS);
^Additional context
src/HealthGPS/data_series.h:29: candidate function not viable: no known conversion from 'bool' to 'core::Gender' for 1st argument
std::vector<double> &operator()(core::Gender gender, const std::string &key);
^
|
Honestly, I don't know this part of the code at all so I have no idea! I'm happy to dig into it if needed though... @jamesturner246 how well do you know it? |
|
Discussed this with @TinyMarsh yesterday. Will add some broken down issues. |
This is by no means a PR with code suggestions. I just wanted to use the diff to facilitate discussion and to get help.
Context: #376. We need to add the ability to group by discrete variables, instead of just age and gender. So if I wanted to group by age and
over_18, I could change the variablegendertoover_18and fetch the correct value from thePersonobject, i.e.entity.over_18.Obviously this isn't going to work as is, for various reasons. Namely that
seriesneeds to be called with a gender, not a bool. And that we need to be able to group by other discrete variables in addition to age/gender, not instead of. But is this at least on the right track or am I barking up the wrong tree?