engraveable + two items that use it #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hold on carousel is doing some cocomelon shit to me |
|
okay that got scope crept a little but its fine. ready for review ❤️ |
|
|
hivehum
changed the title
formlessnameless
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a port of DeltaV-Station/Delta-v#2301 which is a cleanup and port of EngraveableComponent and a trinket that uses it, dogtags, from i believe cosmatic-drift-14/cosmatic-drift#399 but they did not clarify
i took the liberty of changing the locale strings to be more generic to allow better reuse of engraveable. also i think its a really fun admin toy option
oh i also alphabetized the trinket loadout screen because it was bothering me and pinkbat opened #1327 while i was testing so i wanted to cause the worst conflict merge possible
Changelog
🆑