Skip to content
Code Linter (C++)

typo in test_ISFirmwareUpdate.cpp? #2409

Sign in to view logs

typo in test_ISFirmwareUpdate.cpp?

typo in test_ISFirmwareUpdate.cpp? #2409

Triggered via push January 14, 2025 21:12
@kylemallorykylemallory
pushed e7f4e39
SN-6142_multithread-ldp-runner
Status Success
Total duration 37s
Artifacts –

cpp-linter.yml

on: push
cpp-linter
28s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
tests/test_ISFirmwareUpdate.cpp:5:10 [clang-diagnostic-error]: tests/test_ISFirmwareUpdate.cpp#L5
'gtest/gtest.h' file not found
tests/test_ISFirmwareUpdate.cpp:22:20 [cppcoreguidelines-avoid-non-const-global-variables]: tests/test_ISFirmwareUpdate.cpp#L22
variable 'MSG_TYPES' is non-const and globally accessible, consider making it const
tests/test_ISFirmwareUpdate.cpp:24:18 [cppcoreguidelines-avoid-non-const-global-variables]: tests/test_ISFirmwareUpdate.cpp#L24
variable 'fake_md5' is non-const and globally accessible, consider making it const
tests/test_ISFirmwareUpdate.cpp:25:18 [cppcoreguidelines-avoid-non-const-global-variables]: tests/test_ISFirmwareUpdate.cpp#L25
variable 'real_md5' is non-const and globally accessible, consider making it const
tests/test_ISFirmwareUpdate.cpp:39:7 [cppcoreguidelines-special-member-functions]: tests/test_ISFirmwareUpdate.cpp#L39
class 'ExchangeBuffer' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
tests/test_ISFirmwareUpdate.cpp:41:5 [cppcoreguidelines-pro-type-member-init]: tests/test_ISFirmwareUpdate.cpp#L41
constructor does not initialize these fields: buff_size
tests/test_ISFirmwareUpdate.cpp:47:5 [modernize-use-equals-default]: tests/test_ISFirmwareUpdate.cpp#L47
use '= default' to define a trivial destructor
tests/test_ISFirmwareUpdate.cpp:49:9 [modernize-use-trailing-return-type]: tests/test_ISFirmwareUpdate.cpp#L49
use a trailing return type for this function
tests/test_ISFirmwareUpdate.cpp:51:9 [modernize-use-trailing-return-type]: tests/test_ISFirmwareUpdate.cpp#L51
use a trailing return type for this function
tests/test_ISFirmwareUpdate.cpp:51:9 [readability-convert-member-functions-to-static]: tests/test_ISFirmwareUpdate.cpp#L51
method 'removeData' can be made static
tests/test_ISFirmwareUpdate.cpp:51:20 [bugprone-easily-swappable-parameters]: tests/test_ISFirmwareUpdate.cpp#L51
2 adjacent parameters of 'removeData' of similar type ('int') are easily swapped by mistake