Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3636 Fix typo in description and add links to test suite #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yunwwang
Copy link
Collaborator

@yunwwang yunwwang commented Jan 9, 2025

Summary

This PR fixed a typo in test suite description, also add some useful links to the test suite

Testing Guidance

Verify test suite description has the correct "The SMART Health Cards Test Kit"
Verify "Report Issue", "Open Source", "Download", and "SMART Health Cards Framework" links are shown at the page footer

@yunwwang yunwwang requested a review from arscan January 9, 2025 15:15
Copy link

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add in 'SMART Health Cards' as the last link that points to the SHC spec? We usually also put in an 'Implementation Guide' link, but that's not quite accurate here because SHC isn't an IG.

ASTP has specifically asked us to add this link before during reviews for other test kits. We should update our example on the site to include this, but i also think we have other methods of adding standard things like this that hasn't yet been addressed in the docs.

@yunwwang yunwwang requested a review from arscan January 9, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants