FI-2316 Label Reference target profile as MustSupport is there is only one #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammjammjamm
reviewed
Dec 6, 2023
| @@ -254,17 +254,25 @@ def get_type_must_support_metadata(current_metadata, current_element) | |||
| end | |||
|
|
|||
| def handle_type_must_support_target_profiles(type, metadata) | |||
| index = 0 | |||
| return if profile.version == '3.1.1' | |||
There was a problem hiding this comment.
US Core 3 also includes the base FHIR vital signs profiles, which have a different version. I'm guessing that those don't have target profiles and therefore aren't impacted by this change, though.
There was a problem hiding this comment.
That is correct. I will also exclude FHIR R4 profiles for completeness.
| target_profiles << type.targetProfile.first | ||
| else | ||
| index = 0 | ||
| type.source_hash['_targetProfile']&.each do |hash| |
There was a problem hiding this comment.
Ruby can handle the index for you: &.each_with_index do |hash, index|
Jammjammjamm
reviewed
Dec 6, 2023
| element = FHIR::Element.new(hash) | ||
| target_profiles << type.targetProfile[index] if type_must_support_extension?(element.extension) | ||
| end | ||
| index += 1 |
There was a problem hiding this comment.
This one needs to go, too.
There was a problem hiding this comment.
Oh, got it. So the index increase automatically.
arscan
changed the title
Jammjammjamm
reviewed
Dec 8, 2023
| end | ||
|
|
||
| def unresolved_references_strings | ||
| unresolved_reference_hash = | ||
| unresolved_references.each_with_object(Hash.new { |hash, key| hash[key] = [] }) do |missing, hash| | ||
| hash[missing[:path]] << missing[:target_profile] | ||
| end | ||
| unresolved_reference_hash.map { |path, profiles| "#{path}#{"(#{profiles.join('|')})" unless profiles.first.empty?}" } | ||
| unresolved_reference_hash.map { |path, profiles| "#{path} element: Reference(#{profiles.join('|')})" unless profiles.first.empty?}" } |
There was a problem hiding this comment.
There's a syntax error here.
There was a problem hiding this comment.
Forgot to push the last commit
added 9 commits
December 8, 2023 13:42
yunwwang
force-pushed
the
FI-2316-reference-check
branch
from
2421e54 to
81497c9
Compare
Jammjammjamm
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes https://oncprojectracking.healthit.gov/support/browse/FI-2316
This fixes GitHub Issue onc-healthit/onc-certification-g10-test-kit#470
When there is only one target profile for a MustSupport Reference, this profile shall also be treated as MustSupport. This does not affect MustSupport test but enforced reference validation test using the correct profile.
This change exculde US Core v3.1.1 which does not have any target_profile marked, and any FHIR base profiles.
Testing Guidance